[scalardb-cluster] Support Azure Marketplace #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
kota2and3kan
commented
Sep 26, 2024
Comment on lines
+27
to
+29
| {{- if eq .Values.global.platform "azure" }} | ||
| azure-extensions-usage-release-identifier: {{ .Release.Name }} | ||
| {{- end }} |
There was a problem hiding this comment.
This configuration is necessary to charge fees based on the number of pods.
https://learn.microsoft.com/en-us/partner-center/marketplace-offers/azure-container-technical-assets-kubernetes#make-updates-based-on-your-billing-model
Comment on lines
+45
to
+49
| {{- if eq .Values.global.platform "azure" }} | ||
| image: "{{ .Values.global.azure.images.scalardbCluster.registry }}/{{ .Values.global.azure.images.scalardbCluster.image }}:{{ .Values.global.azure.images.scalardbCluster.tag }}" | ||
| {{- else }} | ||
| image: "{{ .Values.scalardbCluster.image.repository }}:{{ .Values.scalardbCluster.image.tag | default .Chart.AppVersion }}" | ||
| {{- end }} |
There was a problem hiding this comment.
We must pull container images from ACR for Azure Marketplace instead of our public container registry.
https://learn.microsoft.com/en-us/partner-center/marketplace-offers/azure-container-technical-assets-kubernetes#update-the-helm-chart
kota2and3kan
requested review from
superbrothers,
a team,
komamitsu,
brfrn169,
feeblefakie and
Torch3333
and removed request for
a team
superbrothers
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the ScalarDB Cluster Helm Chart to support Azure Marketplace.
To list ScalarDB Cluster on the Azure Marketplace, we have to update our helm chart based on the rules of Azure Marketplace. So, I updated ScalarDB Cluster chart as follows:
global.azure.*in thevalues.yamlfile.spec.template.spec.containers[].imagein thedeployment.yamlfile to pull the container image from ACR for Azure Marketplace.azure-extensions-usage-release-identifierlabel in thedeployment.yamlto trace pods and charge license fees by Azure.You can see what we need to list products on the Azure Marketplace in the following Azure document.
Also, to reduce the maintenance cost (avoid duplicated maintenance), I updated the current helm chart instead of creating the Azure Marketplace dedicated helm chart. To achieve that, I added the following things:
global.platformin thevalues.yamlfile.global.platform=azure, ScalarDB Cluster chart use or add the Azure Marketplace dedicated configurations.global.platformconfiguration in both ScalarDB Cluster chart (main chart) and Envoy chart (subchart).Please take a look!
Related issues and/or PRs
I updated the Envoy chart in the following PR.
Changes made
charts/scalardb-cluster/templates/scalardb-cluster/deployment.yamlto add the Azure Marketplace dedicated configurations.charts/scalardb-cluster/values.yamlto add the Azure Marketplace dedicated configurations.charts/scalardb-cluster/README.mdandcharts/scalardb-cluster/values.schema.jsonare updated automatically based onvalues.yaml.Checklist
Additional notes (optional)
N/A
Release notes
N/A